cirno/plan9front
1
0
Fork 0
mirror of git://git.9front.org/plan9front/plan9front synced 2025-01-12 11:10:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ndb/dns: fix memory leak in dnzone()

Browse source
This commit is contained in:
cinap_lenrek 2023-11-02 00:00:22 +00:00
parent f67c4c8523
commit 70dfc2d756
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sys/src/cmd/ndb/dntcpserver.c
View file

@ -216,10 +216,8 @@ dnzone(int fd, uchar *pkt, DNSmsg *reqp, DNSmsg *repp, Request *req, uchar *call
repp->id = reqp->id;
repp->qd = reqp->qd;
reqp->qd = reqp->qd->next;
repp->qd->next = 0;
repp->qd->next = nil;
repp->flags = Fauth | Fresp | Oquery;
if(!cfg.nonrecursive)
repp->flags |= Fcanrec;
setercode(repp, Rok);
dp = repp->qd->owner;
@ -233,12 +231,10 @@ dnzone(int fd, uchar *pkt, DNSmsg *reqp, DNSmsg *repp, Request *req, uchar *call
repp->an = nil;
}
rv = reply(fd, pkt, repp, req, callip);
if(repp->an == nil)
if(rv < 0 || repp->an == nil)
goto out;
rrfreelist(repp->an);
repp->an = nil;
if(rv < 0)
goto out;
repp->an = rrgetzone(dp->name);
while(repp->an != nil) {
@ -254,9 +250,9 @@ dnzone(int fd, uchar *pkt, DNSmsg *reqp, DNSmsg *repp, Request *req, uchar *call
/* resend the soa */
repp->an = rrlookup(dp, Tsoa, NOneg);
rv = reply(fd, pkt, repp, req, callip);
out:
rrfreelist(repp->an);
repp->an = nil;
out:
rrfree(repp->qd);
repp->qd = nil;
return rv;