cirno/plan9front
1
0
Fork 0
mirror of git://git.9front.org/plan9front/plan9front synced 2025-01-12 11:10:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ip/ppp: fix race condition with rfork()

Browse source 
ipinprocpid is static so shared with parent and child,
so we need a temporary variable on the local stack
to properly assign ipinprocpid.
This commit is contained in:
cinap_lenrek 2024-01-05 06:46:35 +00:00
parent 2ca3934809
commit 8d2b84747b
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sys/src/cmd/ip/ppp/ppp.c
View file

@ -1640,7 +1640,7 @@ static char*
ipopen(PPP *ppp)
{
static int ipinprocpid;
int n, cfd, fd;
int n, cfd, fd, pid;
char path[128];
char buf[128];
@ -1676,7 +1676,7 @@ ipopen(PPP *ppp)
close(cfd);
ppp->ipfd = fd;
switch(ipinprocpid = rfork(RFPROC|RFMEM|RFNOWAIT)){
switch(pid = rfork(RFPROC|RFMEM|RFNOWAIT)){
case -1:
terminate(ppp, "forking ipinproc", 1);
case 0:
@ -1684,6 +1684,7 @@ ipopen(PPP *ppp)
terminate(ppp, "ipinproc", 0);
exits(nil);
}
ipinprocpid = pid;
if(validv4(ppp->local)){
if(!validv4(ppp->remote))