cirno/plan9front
1
0
Fork 0
mirror of git://git.9front.org/plan9front/plan9front synced 2025-01-12 11:10:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

hjfs: implement "none" attaches properly

Browse source 
The Tauth for "none" should always fail,
but Tattach should only succeed when
the channel ran a successfull authentication
before.

Also, prevent "none" from attaching "dump".
This commit is contained in:
cinap_lenrek 2024-08-24 23:47:19 +00:00
parent a97ee572b9
commit 9645ae07eb
1 changed files with 21 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
sys/src/cmd/hjfs/9p.c
View file

@ -11,7 +11,8 @@ extern Fs *fsmain;
static void
tauth(Req *req)
{
if((fsmain->flags & FSNOAUTH) != 0)
if((fsmain->flags & FSNOAUTH) != 0
|| strcmp(req->ifcall.uname, "none") == 0)
respond(req, "no authentication required");
else if(*req->ifcall.aname == 0 || strcmp(req->ifcall.aname, "dump") == 0)
auth9p(req);
@ -26,17 +27,32 @@ tattach(Req *req)
int flags;
short uid;
if((fsmain->flags & FSNOAUTH) == 0 && authattach(req) < 0)
return;
if((fsmain->flags & FSNOAUTH) == 0){
if(strcmp(req->ifcall.uname, "none") == 0){
if(!req->srv->authok){
respond(req, "require prior authentication for 'none'");
return;
}
} else {
if(authattach(req) < 0)
return;
req->srv->authok = 1; /* none attaches allowed now */
}
}
if(name2uid(fsmain, req->ifcall.uname, &uid) <= 0){
respond(req, "no such user");
return;
}
if(*req->ifcall.aname == 0)
flags = 0;
else if(strcmp(req->ifcall.aname, "dump") == 0)
else if(strcmp(req->ifcall.aname, "dump") == 0){
if(uid == 0){
/* dont give "none" access to dump */
respond(req, Eperm);
return;
}
flags = CHFDUMP|CHFRO;
else{
} else {
respond(req, Ebadspec);
return;
}