cirno/plan9port
1
0
Fork 0
mirror of https://github.com/9fans/plan9port.git synced 2025-01-24 11:41:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

acme: fix double-free in acmeerrorproc

Browse source 
The receiver of cerr takes ownership of s.
This commit is contained in:
Russ Cox 2021-01-18 14:30:40 -05:00
parent 90971376a5
commit 73661401ea
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/cmd/acme/acme.c
View file

@ -383,7 +383,7 @@ int erroutfd;
void void
acmeerrorproc(void *v) acmeerrorproc(void *v)
{ {
char *buf, *s; char *buf;
int n; int n;
USED(v); USED(v);
@ -391,9 +391,7 @@ acmeerrorproc(void *v)
buf = emalloc(8192+1); buf = emalloc(8192+1);
while((n=read(errorfd, buf, 8192)) >= 0){ while((n=read(errorfd, buf, 8192)) >= 0){
buf[n] = '\0'; buf[n] = '\0';
s = estrdup(buf); sendp(cerr, estrdup(buf));
sendp(cerr, s);
free(s);
} }
free(buf); free(buf);
} }