mirror of
https://github.com/9fans/plan9port.git
synced 2025-01-12 11:10:07 +00:00
upas: fix warnings
smtp.c:232: warning: comparison with string literal results in unspecified behavior smtp.c:244: warning: comparison with string literal results in unspecified behavior marshal.c:1179: warning: variable ‘err’ set but not used LGTM=rsc R=rsc https://codereview.appspot.com/93290043
This commit is contained in:
parent
954e03ccfe
commit
bae34df843
2 changed files with 3 additions and 3 deletions
|
@ -1183,7 +1183,7 @@ waitforsubprocs(void)
|
|||
err = w->msg;
|
||||
if(pid >= 0 && (w=procwait(pid)) && w->msg[0])
|
||||
err = w->msg;
|
||||
return nil;
|
||||
return err;
|
||||
}
|
||||
|
||||
int
|
||||
|
|
|
@ -229,7 +229,7 @@ threadmain(int argc, char **argv)
|
|||
for(i = 0; i < argc; i++){
|
||||
if((trv = rcptto(argv[i])) != 0){
|
||||
/* remember worst error */
|
||||
if(rv != Giveup)
|
||||
if(strcmp(rv, Giveup) != 0)
|
||||
rv = trv;
|
||||
errs[rcvrs] = strdup(s_to_c(reply));
|
||||
removenewline(errs[rcvrs]);
|
||||
|
@ -241,7 +241,7 @@ threadmain(int argc, char **argv)
|
|||
}
|
||||
|
||||
/* if no ok rcvrs or worst error is retry, give up */
|
||||
if(ok == 0 || rv == Retry)
|
||||
if(ok == 0 || strcmp(rv, Retry) == 0)
|
||||
goto error;
|
||||
|
||||
if(ping){
|
||||
|
|
Loading…
Reference in a new issue